Add support for Russian, Ukrainian and Bulgarian#12
Open
vlevit wants to merge 1 commit intonschum:masterfrom
Open
Add support for Russian, Ukrainian and Bulgarian#12vlevit wants to merge 1 commit intonschum:masterfrom
vlevit wants to merge 1 commit intonschum:masterfrom
Conversation
|
I am not the maintainer of this project, but if you would want this to get merged, I suggest you fix the build issues:
|
Author
|
Those 3 lines are source URLs in comments. I believe URLs must not be wrapped. I can make those lines fit 80 margin but formatting will look uglier. The proper fix would be to improve linter not to give false positives on strings that can't be wrapped ( |
|
Sorry, I missed that! You only can wait for @nschum to merge or comment... |
Author
|
Thanks! I have contacted @nschum, now waiting for the response. |
stasvlasov
pushed a commit
to stasvlasov/auto-dictionary-mode
that referenced
this pull request
Aug 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.